Skip to content

Address review comments from #993 #1005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 9, 2024
Merged

Address review comments from #993 #1005

merged 2 commits into from
Jan 9, 2024

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Dec 19, 2023

  • Refactor rename to avoid a force unwrap
  • Refactor multi-file rename tests to specify expected renamed source instead of asserting on edits

@ahoppen ahoppen requested a review from bnbarham December 19, 2023 18:55
@ahoppen ahoppen requested a review from benlangmuir as a code owner December 19, 2023 18:55
@ahoppen
Copy link
Member Author

ahoppen commented Dec 19, 2023

@swift-ci Please test

@ahoppen
Copy link
Member Author

ahoppen commented Jan 8, 2024

@swift-ci Please test

@ahoppen ahoppen enabled auto-merge January 8, 2024 21:24
@ahoppen ahoppen merged commit 2f80cca into swiftlang:main Jan 9, 2024
@ahoppen ahoppen deleted the ahoppen/global-rename-review branch January 9, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnbarham bnbarham bnbarham approved these changes

@benlangmuir benlangmuir Awaiting requested review from benlangmuir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahoppen @bnbarham